Re: [PATCH v15 1/2] thermal: loongson-2: add thermal management support

[Yinbo Zhu]

在 2023/8/16 下午8:46, Daniel Lezcano 写道:
> On 20/06/2023 03:29, Yinbo Zhu wrote:
> > This patch adds the support for Loongson-2 thermal sensor controller,
> > which can support maximum four sensor selectors that corresponding to 
> > four
> > sets of thermal control registers and one set of sampling register. The
> > sensor selector can selector a speific thermal sensor as temperature 
> > input.
> > The sampling register is used to obtain the temperature in real time, the
> > control register GATE field is used to set the threshold of high or low
> > temperature, when the input temperature is higher than the high 
> > temperature
> > threshold or lower than the low temperature threshold, an interrupt will
> > occur.
> >
> > Signed-off-by: zhanghongchen <zhanghongchen@xxxxxxxxxxx>
> > Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
> > ---
>
> [ ... ]
>
> > +    if (devm_thermal_add_hwmon_sysfs(dev, tzd))
> > +        dev_warn(dev, "Failed to add hwmon sysfs attributes\n");
>
> [ ... ]
>
> This has been factored out by adding a message directly in 
> devm_thermal_add_hwmon_sysfs(), so the test is not needed here neither 
> the message.


okay, I got it, I will remove the message.

> However, these changes have been long enough on the mailing list and the 
> result looks nice.
>
> I can pick this patch and you provide a small patch on top. Or you send 
> a V16 with this change. It is your call.


okay, I will send v16.

Thanks,
Yinbo.