Re: [PATCH v12 9/9] ACPI: x86: s2idle: Enforce LPS0 constraints for PCI devices
From: kernel test robot
Date: Thu Aug 17 2023 - 01:10:03 EST
Hi Mario,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 2ccdd1b13c591d306f0401d98dedc4bdcd02b421]
url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/ACPI-Add-comments-to-clarify-some-ifdef-statements/20230817-061259
base: 2ccdd1b13c591d306f0401d98dedc4bdcd02b421
patch link: https://lore.kernel.org/r/20230816204143.66281-10-mario.limonciello%40amd.com
patch subject: [PATCH v12 9/9] ACPI: x86: s2idle: Enforce LPS0 constraints for PCI devices
config: i386-randconfig-i063-20230817 (https://download.01.org/0day-ci/archive/20230817/202308171239.xQFwhccA-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308171239.xQFwhccA-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308171239.xQFwhccA-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> drivers/acpi/x86/s2idle.c:306:67: sparse: sparse: restricted pci_power_t degrades to integer
>> drivers/acpi/x86/s2idle.c:306:45: sparse: sparse: incorrect type in initializer (different base types) @@ expected restricted pci_power_t [usertype] target @@ got int @@
drivers/acpi/x86/s2idle.c:306:45: sparse: expected restricted pci_power_t [usertype] target
drivers/acpi/x86/s2idle.c:306:45: sparse: got int
drivers/acpi/x86/s2idle.c:312:13: sparse: sparse: restricted pci_power_t degrades to integer
>> drivers/acpi/x86/s2idle.c:318:17: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected int state @@ got restricted pci_power_t [usertype] current_state @@
drivers/acpi/x86/s2idle.c:318:17: sparse: expected int state
drivers/acpi/x86/s2idle.c:318:17: sparse: got restricted pci_power_t [usertype] current_state
>> drivers/acpi/x86/s2idle.c:318:17: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected int state @@ got restricted pci_power_t [usertype] target @@
drivers/acpi/x86/s2idle.c:318:17: sparse: expected int state
drivers/acpi/x86/s2idle.c:318:17: sparse: got restricted pci_power_t [usertype] target
drivers/acpi/x86/s2idle.c:522:13: sparse: sparse: restricted suspend_state_t degrades to integer
drivers/acpi/x86/s2idle.c:522:33: sparse: sparse: restricted suspend_state_t degrades to integer
vim +306 drivers/acpi/x86/s2idle.c
303
304 static void lpi_check_pci_dev(struct lpi_constraints *entry, struct pci_dev *pdev)
305 {
> 306 pci_power_t target = entry->enabled ? entry->min_dstate : PCI_D0;
307
308 if (pdev->current_state == target)
309 return;
310
311 /* constraint of ACPI D3hot means PCI D3hot _or_ D3cold */
312 if (target == ACPI_STATE_D3_HOT &&
313 (pdev->current_state == PCI_D3hot ||
314 pdev->current_state == PCI_D3cold))
315 return;
316
317 if (pm_debug_messages_on)
> 318 acpi_handle_info(entry->handle,
319 "LPI: PCI device in %s, not in %s\n",
320 acpi_power_state_string(pdev->current_state),
321 acpi_power_state_string(target));
322
323 /* don't try with things that PCI core hasn't touched */
324 if (pdev->current_state == PCI_UNKNOWN) {
325 entry->handle = NULL;
326 return;
327 }
328
329 pci_set_power_state(pdev, target);
330 }
331
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki