Re: [PATCH] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29_curiosity board

[claudiu beznea]

On 8/16/23 12:05, Mihai.Sain@xxxxxxxxxxxxx wrote:
> Hi Claudiu,
> 
> ----------------------
> 
> Hi, Mihai,
> 
> On 8/10/23 09:47, Mihai.Sain@xxxxxxxxxxxxx wrote:
>>> +&i2s0 {
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2s0_default>;
>>> +     status = "okay";
>> I see no sound bindings on DT. Is there any reason for having this here?
>> # i2s0 bus is wired to RPi 40-pin connector. I want to have this node and its pinctrl here.
>> # i2c1, flx4-spi, pwm0, uart1 are also wired to Rpi connector, and are defined here.
>> # The same logic we apply also for mikroBUS sockets: i2c, pwm, spi and uart nodes are defined here.
>>
> 
> Can you use it (either with user space tools or other kernel consumers) w/o additional device tree bindings?
> # Yes. We have added in dt-overlay the codec which uses the i2s0 and i2c1 nodes and pinctrls.

overlay means additional DT bindings to me. So, I suggest to move the i2s
node there, too. It is the same approach that you've taken for ethernet node.