drivers/i3c/master/svc-i3c-master.c:204: warning: Function parameter or member 'saved_regs' not described in 'svc_i3c_master'
From: kernel test robot
Date: Thu Aug 17 2023 - 02:49:52 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6
commit: 1c5ee2a77b1bacd4c333bebea93610aaf17977be i3c: master: svc: fix i3c suspend/resume issue
date: 2 months ago
config: microblaze-randconfig-r025-20230817 (https://download.01.org/0day-ci/archive/20230817/202308171435.0xQ82lvu-lkp@xxxxxxxxx/config)
compiler: microblaze-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308171435.0xQ82lvu-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308171435.0xQ82lvu-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/i3c/master/svc-i3c-master.c:204: warning: Function parameter or member 'saved_regs' not described in 'svc_i3c_master'
vim +204 drivers/i3c/master/svc-i3c-master.c
1c5ee2a77b1bac Clark Wang 2023-05-17 152
dd3c52846d5954 Miquel Raynal 2021-01-21 153 /**
dd3c52846d5954 Miquel Raynal 2021-01-21 154 * struct svc_i3c_master - Silvaco I3C Master structure
dd3c52846d5954 Miquel Raynal 2021-01-21 155 * @base: I3C master controller
dd3c52846d5954 Miquel Raynal 2021-01-21 156 * @dev: Corresponding device
dd3c52846d5954 Miquel Raynal 2021-01-21 157 * @regs: Memory mapping
dd3c52846d5954 Miquel Raynal 2021-01-21 158 * @free_slots: Bit array of available slots
dd3c52846d5954 Miquel Raynal 2021-01-21 159 * @addrs: Array containing the dynamic addresses of each attached device
dd3c52846d5954 Miquel Raynal 2021-01-21 160 * @descs: Array of descriptors, one per attached device
dd3c52846d5954 Miquel Raynal 2021-01-21 161 * @hj_work: Hot-join work
dd3c52846d5954 Miquel Raynal 2021-01-21 162 * @ibi_work: IBI work
dd3c52846d5954 Miquel Raynal 2021-01-21 163 * @irq: Main interrupt
dd3c52846d5954 Miquel Raynal 2021-01-21 164 * @pclk: System clock
dd3c52846d5954 Miquel Raynal 2021-01-21 165 * @fclk: Fast clock (bus)
dd3c52846d5954 Miquel Raynal 2021-01-21 166 * @sclk: Slow clock (other events)
dd3c52846d5954 Miquel Raynal 2021-01-21 167 * @xferqueue: Transfer queue structure
dd3c52846d5954 Miquel Raynal 2021-01-21 168 * @xferqueue.list: List member
dd3c52846d5954 Miquel Raynal 2021-01-21 169 * @xferqueue.cur: Current ongoing transfer
dd3c52846d5954 Miquel Raynal 2021-01-21 170 * @xferqueue.lock: Queue lock
dd3c52846d5954 Miquel Raynal 2021-01-21 171 * @ibi: IBI structure
dd3c52846d5954 Miquel Raynal 2021-01-21 172 * @ibi.num_slots: Number of slots available in @ibi.slots
dd3c52846d5954 Miquel Raynal 2021-01-21 173 * @ibi.slots: Available IBI slots
dd3c52846d5954 Miquel Raynal 2021-01-21 174 * @ibi.tbq_slot: To be queued IBI slot
dd3c52846d5954 Miquel Raynal 2021-01-21 175 * @ibi.lock: IBI lock
dd3c52846d5954 Miquel Raynal 2021-01-21 176 */
dd3c52846d5954 Miquel Raynal 2021-01-21 177 struct svc_i3c_master {
dd3c52846d5954 Miquel Raynal 2021-01-21 178 struct i3c_master_controller base;
dd3c52846d5954 Miquel Raynal 2021-01-21 179 struct device *dev;
dd3c52846d5954 Miquel Raynal 2021-01-21 180 void __iomem *regs;
1c5ee2a77b1bac Clark Wang 2023-05-17 181 struct svc_i3c_regs_save saved_regs;
dd3c52846d5954 Miquel Raynal 2021-01-21 182 u32 free_slots;
dd3c52846d5954 Miquel Raynal 2021-01-21 183 u8 addrs[SVC_I3C_MAX_DEVS];
dd3c52846d5954 Miquel Raynal 2021-01-21 184 struct i3c_dev_desc *descs[SVC_I3C_MAX_DEVS];
dd3c52846d5954 Miquel Raynal 2021-01-21 185 struct work_struct hj_work;
dd3c52846d5954 Miquel Raynal 2021-01-21 186 struct work_struct ibi_work;
dd3c52846d5954 Miquel Raynal 2021-01-21 187 int irq;
dd3c52846d5954 Miquel Raynal 2021-01-21 188 struct clk *pclk;
dd3c52846d5954 Miquel Raynal 2021-01-21 189 struct clk *fclk;
dd3c52846d5954 Miquel Raynal 2021-01-21 190 struct clk *sclk;
dd3c52846d5954 Miquel Raynal 2021-01-21 191 struct {
dd3c52846d5954 Miquel Raynal 2021-01-21 192 struct list_head list;
dd3c52846d5954 Miquel Raynal 2021-01-21 193 struct svc_i3c_xfer *cur;
dd3c52846d5954 Miquel Raynal 2021-01-21 194 /* Prevent races between transfers */
dd3c52846d5954 Miquel Raynal 2021-01-21 195 spinlock_t lock;
dd3c52846d5954 Miquel Raynal 2021-01-21 196 } xferqueue;
dd3c52846d5954 Miquel Raynal 2021-01-21 197 struct {
dd3c52846d5954 Miquel Raynal 2021-01-21 198 unsigned int num_slots;
dd3c52846d5954 Miquel Raynal 2021-01-21 199 struct i3c_dev_desc **slots;
dd3c52846d5954 Miquel Raynal 2021-01-21 200 struct i3c_ibi_slot *tbq_slot;
dd3c52846d5954 Miquel Raynal 2021-01-21 201 /* Prevent races within IBI handlers */
dd3c52846d5954 Miquel Raynal 2021-01-21 202 spinlock_t lock;
dd3c52846d5954 Miquel Raynal 2021-01-21 203 } ibi;
dd3c52846d5954 Miquel Raynal 2021-01-21 @204 };
dd3c52846d5954 Miquel Raynal 2021-01-21 205
:::::: The code at line 204 was first introduced by commit
:::::: dd3c52846d5954acd43f0e771689302f27dadc28 i3c: master: svc: Add Silvaco I3C master driver
:::::: TO: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
:::::: CC: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki