Re: [PATCH] riscv: suspend: Add syscore ops for suspend

[Nick Hu]

Hi Conor

On Wed, Aug 16, 2023 at 8:34 PM Conor Dooley <conor.dooley@xxxxxxxxxxxxx> wrote:
>
> On Wed, Aug 16, 2023 at 11:40:09AM +0800, Nick Hu wrote:
> > Save and restore the FPU and vector states when system suspend. If a
> > task is the one who performs the suspend flow and it also do some
> > floating or vector operations before the suspend, we should save and
> > restore the FPU states and vector states for this task.
> >
> > Signed-off-by: Nick Hu <nick.hu@xxxxxxxxxx>
>
> > Signed-off-by: Andy Chiu <andy.chiu@xxxxxxxxxx>
>
> What was Andy's contribution to the patch?
> Are you missing a co-developed-by tag?
>
He fixed something related to vector.
I'll add co-developed-by in the next version.

> Also, I'm a bit confused by the commit message due to a lack of
> knowledge here - is this a fix or a new feature?
> It reads as if things are not being saved/restored correctly, but
> there's no "fix" related keywords in the commit message nor a Fixes:
> tag.
>
> Thanks,
> Conor.
I'll rephrase the commit message.
Thanks for the feedback.

Thanks,
Nick