Re: [PATCH v4 0/5] Add LVTS support for mt8192

From: Chen-Yu Tsai
Date: Thu Aug 17 2023 - 04:47:00 EST


On Thu, Aug 17, 2023 at 4:49 AM Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:
>
>
> Hi,
>
> On 16/08/2023 21:57, Nícolas F. R. A. Prado wrote:
>
> [ ... ]
>
> > Hi Daniel,
> >
> > just a gentle reminder. As you've just applied [1], there are no longer any
> > concerns with this series, and it'll provide both working interrupts and
> > reliable thermal readings on MT8192.
>
> There are still concerns and questions in the series for patch2 and 3.

FWIW the readout errors raised in patch 3 were fixed by

"thermal/drivers/mediatek/lvts_thermal: Make readings valid in filtered mode"

So I guess the remaining concern is on patch 2 about whether the noirq
suspend callback should be used instead.

ChenYu