Re: [PATCH net-next 4/6] net/smc: support max connections per lgr negotiation

From: Guangguan Wang
Date: Thu Aug 17 2023 - 05:26:27 EST




On 2023/8/17 14:42, Jan Karcher wrote:
>
>
> On 16/08/2023 10:33, Guangguan Wang wrote:
...
>> @@ -1163,6 +1173,11 @@ int smc_clc_srv_v2x_features_validate(struct smc_clc_msg_proposal *pclc,
>>   {
>>       struct smc_clc_v2_extension *pclc_v2_ext;
>>   +    /* default max conn is SMC_CONN_PER_LGR_MAX(255),
>> +     * which is the default value in smc v1 and v2.0.
>> +     */
>
> I'm afraid this comment is not going to age well. You already put this to the define itself so i plea to remove it here.
>
> Thank you.
> - Jan
>

Get it, Thanks.