Re: drivers/gpio/gpio-pca9570.c:42: warning: Function parameter or member 'chip_data' not described in 'pca9570'

[Andy Shevchenko]

On Thu, Aug 17, 2023 at 03:11:09PM +0800, kernel test robot wrote:
> Hi Bartosz,

...

> >> drivers/gpio/gpio-pca9570.c:42: warning: Function parameter or member 'chip_data' not described in 'pca9570'

Blame Bart for this :-)

> b8a34582c7f7f2 Shubhrajyoti Datta  2022-10-26  29  
> 16d44b6085c1d9 Sungbo Eo           2020-07-09  30  /**
> 16d44b6085c1d9 Sungbo Eo           2020-07-09  31   * struct pca9570 - GPIO driver data
> 16d44b6085c1d9 Sungbo Eo           2020-07-09  32   * @chip: GPIO controller chip
> b8a34582c7f7f2 Shubhrajyoti Datta  2022-10-26  33   * @p_data: GPIO controller platform data


So, should be @chip_data...

> 16d44b6085c1d9 Sungbo Eo           2020-07-09  34   * @lock: Protects write sequences
> 16d44b6085c1d9 Sungbo Eo           2020-07-09  35   * @out: Buffer for device register
> 16d44b6085c1d9 Sungbo Eo           2020-07-09  36   */
> 16d44b6085c1d9 Sungbo Eo           2020-07-09  37  struct pca9570 {
> 16d44b6085c1d9 Sungbo Eo           2020-07-09  38  	struct gpio_chip chip;
> a3f7c1d6ddcbd4 Bartosz Golaszewski 2022-12-30  39  	const struct pca9570_chip_data *chip_data;
> 16d44b6085c1d9 Sungbo Eo           2020-07-09  40  	struct mutex lock;
> 16d44b6085c1d9 Sungbo Eo           2020-07-09  41  	u8 out;
> 16d44b6085c1d9 Sungbo Eo           2020-07-09 @42  };

-- 
With Best Regards,
Andy Shevchenko