Re: [PATCH 2/2] coresight: trbe: Allocate platform data per device

[Suzuki K Poulose]

On 17/08/2023 11:16, Anshuman Khandual wrote:
> On 8/17/23 15:31, Suzuki K Poulose wrote:
> > On 17/08/2023 10:24, James Clark wrote:
> > > On 17/08/2023 07:37, Anshuman Khandual wrote:
> > > > Hi Suzuki,
> > > >
> > > > Seems like this patch is going to conflict with the below proposed change
> > > >
> > > > https://lore.kernel.org/all/20230817055405.249630-4-anshuman.khandual@xxxxxxx/
> > > >
> > > > Please let me know how should we resolve this conflict.
> > >
> > > We could merge them both, with the fixes: one first, just to acknowledge
> > > that there was a problem. But I suppose your one will have to be rebased
> > > on top.
> > >
> > > > On 8/16/23 19:40, Suzuki K Poulose wrote:
> > > > > Coresight TRBE driver shares a single platform data (which is empty btw).
> > > > > However, with the commit 4e8fe7e5c3a5
> > > > > ("coresight: Store pointers to connections rather than an array of them")
> > > > > the coresight core would free up the pdata, resulting in multiple attempts
> > > > > to free the same pdata for TRBE instances. Fix this by allocating a pdata per
> > > > > coresight_device.
> > > > >
> > > > > Fixes: 3fbf7f011f24 ("coresight: sink: Add TRBE driver")
> > > >
> > > > The above mentioned commit i.e 4e8fe7e5c3a5 seems to be a more recent one which
> > > > has triggered this problem. But would the problem be still there without that ?
> > > > Else 'Fixes:' tag would need changing.
> > >
> > > Yes I think the fixes tag should point to 4e8fe7e5c3a5.
> >
> > Agreed, I will change the fixes tag and push this.
>
> In the first patch, the last hunk might not be required to fix the
> IPI problem and in fact might be bit problematic as well. Besides,

Please could you comment your concerns on the patch ?

Suzuki

> could you please hold off pushing this change into coresight tree
> for some time ?