Re: [PATCH v5 3/7] perf record: Move setting dummy tracking before record__init_thread_masks()

[Yang Jihong]

Hello,

On 2023/8/15 9:57, Yang Jihong wrote:
> Hello,
>
> On 2023/8/15 4:29, Ian Rogers wrote:
> > On Thu, Aug 3, 2023 at 11:58 PM Adrian Hunter 
> > <adrian.hunter@xxxxxxxxx> wrote:
> > > On 4/08/23 05:07, Yang Jihong wrote:
> > > > When dummy tracking go system wide, the mmap cpu mask is changed.
> >
> > As previously commented, can we improve the quality of the function
> > names and commit messages? This sentence is particularly difficult to
> > understand, I don't understand it.
>
> OK. The commit messages will be modified. Please check whether the 
> following description is clear:
>
> User space tasks can migrate between CPUs, so when tracing selected 
> CPUs, sideband for all CPUs is needed. In this case set the cpu map of 
> the evsel to all online CPUs. This may modify the original cpu map of 
> the evlist.
> Therefore, need to check whether the preceding scenario exists before 
> record__init_thread_masks().
> Dummy tracking has been set in record__open(), move it before 
> record__init_thread_masks() and add a helper for unified processing.
Ian, do you have any questions about the commit message above? If it's 
okay, I'll send the next version as above.

Thanks,
Yang