drivers/firmware/efi/libstub/alignedmem.c:27: warning: Function parameter or member 'memory_type' not described in 'efi_allocate_pages_aligned'

From: kernel test robot
Date: Thu Aug 17 2023 - 10:05:17 EST


Hi Ard,

First bad commit (maybe != root cause):

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6
commit: 9cf42bca30e98a1c6c9e8abf876940a551eaa3d1 efi: libstub: use EFI_LOADER_CODE region when moving the kernel in memory
date: 9 months ago
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20230817/202308172116.yPoBelLU-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172116.yPoBelLU-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308172116.yPoBelLU-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/firmware/efi/libstub/alignedmem.c:27: warning: Function parameter or member 'memory_type' not described in 'efi_allocate_pages_aligned'


vim +27 drivers/firmware/efi/libstub/alignedmem.c

43b1df0e013c25 Ard Biesheuvel 2020-03-27 7
43b1df0e013c25 Ard Biesheuvel 2020-03-27 8 /**
43b1df0e013c25 Ard Biesheuvel 2020-03-27 9 * efi_allocate_pages_aligned() - Allocate memory pages
43b1df0e013c25 Ard Biesheuvel 2020-03-27 10 * @size: minimum number of bytes to allocate
43b1df0e013c25 Ard Biesheuvel 2020-03-27 11 * @addr: On return the address of the first allocated page. The first
43b1df0e013c25 Ard Biesheuvel 2020-03-27 12 * allocated page has alignment EFI_ALLOC_ALIGN which is an
43b1df0e013c25 Ard Biesheuvel 2020-03-27 13 * architecture dependent multiple of the page size.
43b1df0e013c25 Ard Biesheuvel 2020-03-27 14 * @max: the address that the last allocated memory page shall not
43b1df0e013c25 Ard Biesheuvel 2020-03-27 15 * exceed
43b1df0e013c25 Ard Biesheuvel 2020-03-27 16 * @align: minimum alignment of the base of the allocation
43b1df0e013c25 Ard Biesheuvel 2020-03-27 17 *
43b1df0e013c25 Ard Biesheuvel 2020-03-27 18 * Allocate pages as EFI_LOADER_DATA. The allocated pages are aligned according
43b1df0e013c25 Ard Biesheuvel 2020-03-27 19 * to @align, which should be >= EFI_ALLOC_ALIGN. The last allocated page will
43b1df0e013c25 Ard Biesheuvel 2020-03-27 20 * not exceed the address given by @max.
43b1df0e013c25 Ard Biesheuvel 2020-03-27 21 *
43b1df0e013c25 Ard Biesheuvel 2020-03-27 22 * Return: status code
43b1df0e013c25 Ard Biesheuvel 2020-03-27 23 */
43b1df0e013c25 Ard Biesheuvel 2020-03-27 24 efi_status_t efi_allocate_pages_aligned(unsigned long size, unsigned long *addr,
9cf42bca30e98a Ard Biesheuvel 2022-08-02 25 unsigned long max, unsigned long align,
9cf42bca30e98a Ard Biesheuvel 2022-08-02 26 int memory_type)
43b1df0e013c25 Ard Biesheuvel 2020-03-27 @27 {

:::::: The code at line 27 was first introduced by commit
:::::: 43b1df0e013c25abb536699f46d0e9f291b586a0 efi/libstub: Add API function to allocate aligned memory

:::::: TO: Ard Biesheuvel <ardb@xxxxxxxxxx>
:::::: CC: Ard Biesheuvel <ardb@xxxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki