Re: [PATCH] drivers: nvdimm: fix memleak

[Dave Jiang]

On 8/17/23 04:59, Konstantin Meskhidze wrote:
> Memory pointed by 'nd_pmu->pmu.attr_groups' is allocated in function
> 'register_nvdimm_pmu' and is lost after 'kfree(nd_pmu)' call in function
> 'unregister_nvdimm_pmu'.
>
> Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@xxxxxxxxxx>

Applied and changed subject to:
nvdimm: Fix memleak of pmu attr_groups in unregister_nvdimm_pmu()

Also added fixes tag:
Fixes: 0fab1ba6ad6b ("drivers/nvdimm: Add perf interface to expose 
nvdimm performance stats")


> ---
>   drivers/nvdimm/nd_perf.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c
> index 433bbb68a..14881c4e0 100644
> --- a/drivers/nvdimm/nd_perf.c
> +++ b/drivers/nvdimm/nd_perf.c
> @@ -323,7 +323,8 @@ EXPORT_SYMBOL_GPL(register_nvdimm_pmu);
>   void unregister_nvdimm_pmu(struct nvdimm_pmu *nd_pmu)
>   {
>   	perf_pmu_unregister(&nd_pmu->pmu);
>   	nvdimm_pmu_free_hotplug_memory(nd_pmu);
> +	kfree(nd_pmu->pmu.attr_groups);
>   	kfree(nd_pmu);
>   }
>   EXPORT_SYMBOL_GPL(unregister_nvdimm_pmu);