Re: [RFC PATCH 2/2] kselftest: Add Devicetree unprobed devices test
From: Nícolas F. R. A. Prado
Date: Thu Aug 17 2023 - 12:18:38 EST
On Thu, Aug 17, 2023 at 01:26:05PM +0100, Mark Brown wrote:
> On Fri, Aug 11, 2023 at 10:16:52AM -0400, Nícolas F. R. A. Prado wrote:
> > On Fri, Aug 11, 2023 at 02:54:56PM +0100, Mark Brown wrote:
>
> > > This doesn't appear to produce KTAP output which is going to make it
> > > less useful for generic kselftest runners.
>
> > Right, I'm going to need to rewrite it in C for that, but since I already had
> > the shell script done, I decided to send it as is for the RFC, since I wanted to
> > get feedback on the general approach more than anything.
>
> I'm not clear why KTAP would require C?
When going through the documentation there was only mention of the C headers for
the kselftest framework which outputs using the KTAP format, so I thought that
was the only acceptable option.
But in the meantime while looking through the other tests I saw you've recently
added ktap output to ftrace/ftracetest. The newly added test in
net/mptcp/mptcp_lib.sh also has its own helpers for outputting in KTAP. There
are also a couple other cases of this in python.
So I can definitely do the same for this test.
Thanks,
Nícolas