drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:73: warning: Function parameter or member 'opcode' not described in 'bnxt_qplib_map_rc'

From: kernel test robot
Date: Thu Aug 17 2023 - 12:21:52 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6
commit: 3022cc15119733cebaef05feddb5d87b9e401c0e RDMA/bnxt_re: Avoid the command wait if firmware is inactive
date: 9 weeks ago
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230818/202308180055.6zM4AK6V-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230818/202308180055.6zM4AK6V-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308180055.6zM4AK6V-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:73: warning: Function parameter or member 'opcode' not described in 'bnxt_qplib_map_rc'
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:105: warning: Function parameter or member 'rcfw' not described in '__wait_for_resp'
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:105: warning: Function parameter or member 'cookie' not described in '__wait_for_resp'
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:105: warning: Function parameter or member 'opcode' not described in '__wait_for_resp'
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:147: warning: Function parameter or member 'rcfw' not described in '__block_for_resp'
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:147: warning: Function parameter or member 'cookie' not described in '__block_for_resp'
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:147: warning: Function parameter or member 'opcode' not described in '__block_for_resp'


vim +73 drivers/infiniband/hw/bnxt_re/qplib_rcfw.c

55
56 /**
57 * bnxt_qplib_map_rc - map return type based on opcode
58 * @opcode - roce slow path opcode
59 *
60 * In some cases like firmware halt is detected, the driver is supposed to
61 * remap the error code of the timed out command.
62 *
63 * It is not safe to assume hardware is really inactive so certain opcodes
64 * like destroy qp etc are not safe to be returned success, but this function
65 * will be called when FW already reports a timeout. This would be possible
66 * only when FW crashes and resets. This will clear all the HW resources.
67 *
68 * Returns:
69 * 0 to communicate success to caller.
70 * Non zero error code to communicate failure to caller.
71 */
72 static int bnxt_qplib_map_rc(u8 opcode)
> 73 {
74 switch (opcode) {
75 case CMDQ_BASE_OPCODE_DESTROY_QP:
76 case CMDQ_BASE_OPCODE_DESTROY_SRQ:
77 case CMDQ_BASE_OPCODE_DESTROY_CQ:
78 case CMDQ_BASE_OPCODE_DEALLOCATE_KEY:
79 case CMDQ_BASE_OPCODE_DEREGISTER_MR:
80 case CMDQ_BASE_OPCODE_DELETE_GID:
81 case CMDQ_BASE_OPCODE_DESTROY_QP1:
82 case CMDQ_BASE_OPCODE_DESTROY_AH:
83 case CMDQ_BASE_OPCODE_DEINITIALIZE_FW:
84 case CMDQ_BASE_OPCODE_MODIFY_ROCE_CC:
85 case CMDQ_BASE_OPCODE_SET_LINK_AGGR_MODE:
86 return 0;
87 default:
88 return -ETIMEDOUT;
89 }
90 }
91

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki