Re: [PATCH v2] ext4: mballoc: avoid garbage value from err

From: Theodore Ts'o
Date: Fri Aug 18 2023 - 01:06:47 EST



On Tue, 25 Jul 2023 12:33:11 +0800, Su Hui wrote:
> clang's static analysis warning: fs/ext4/mballoc.c
> line 4178, column 6, Branch condition evaluates to a garbage value.
>
> err is uninitialized and will be judged when 'len <= 0' or
> it first enters the loop while the condition "!ext4_sb_block_valid()"
> is true. Although this can't make problems now, it's better to
> correct it.
>
> [...]

Applied, thanks!

[1/1] ext4: mballoc: avoid garbage value from err
commit: f2060a35e10fc3db2950e98f5b7f6f55ad4e4079

Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>