Re: [PATCH 4/4] crypto: qat - add pm_status debugfs file
From: Herbert Xu
Date: Fri Aug 18 2023 - 04:52:08 EST
On Fri, Aug 18, 2023 at 11:46:55AM +0300, Andy Shevchenko wrote:
>
> Splitting ARRAY_SIZE() is very beneficial on its own.
> The static assert is slightly more robust for the big code then defining
> something that at some point can be missed or miscalculated. Yet we can
> survive with a macro if you thinks it's better.
Yes please go ahead with just a macro.
If the ARRYA_SIZE thing turns out to be useful for other people I'm
sure it'll be added. But I don't see much value in this particular
use.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt