Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent

From: suijingfeng
Date: Fri Aug 18 2023 - 05:33:43 EST


Hi,


On 2023/8/18 06:08, Bjorn Helgaas wrote:
This patch makes the vga_is_firmware_default() function works on whatever
arch that has UEFI GOP support. But we make it available only on platforms
where PCI resource relocation happens. if the provided method proves to be
effective and reliable, it can be expanded to other arch easily.

v2:
* Fix test robot warnnings and fix typos

v3:
* Fix linkage problems if the global screen_info is not exported

v4:
* Handle linkage problems by hiding behind of CONFIG_SYSFB,
* Drop side-effects and simplify.
The v2, v3, v4 changelog is nice, but we don't need it in the commit
log itself, where it will become part of the git history. It should
go in a cover letter or after the "---" marker:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.0#n678

Thanks for point it out, now I know. Will be fixed at the next version.