Re: [PATCH v2] serial: 8250_bcm7271: improve bcm7271 8250 port

From: Andy Shevchenko
Date: Fri Aug 18 2023 - 07:00:25 EST


On Thu, Aug 17, 2023 at 02:13:18PM -0700, Justin Chen wrote:
> The 8250 BCM7271 UART is not a direct match to PORT_16550A and other
> generic ports do not match its hardware capabilities. PORT_ALTR matches
> the rx trigger levels, but its vendor configurations are not compatible.
> Unfortunately this means we need to create another port to fully capture
> the hardware capabilities of the BCM7271 UART.
>
> To alleviate some latency pressures, we default the rx trigger level to 8.

...

> + .flags = UART_CAP_FIFO | UART_CAP_AFE

Leave trailing comma

...

> +/* Broadcom BCM7271 UART */
> +#define PORT_BCM7271 76

13 is free why not using it?


--
With Best Regards,
Andy Shevchenko