RE: [PATCH v4 2/2] gpio: mlxbf3: Support add_pin_ranges()
From: Asmaa Mnebhi
Date: Fri Aug 18 2023 - 10:29:09 EST
> > Support add_pin_ranges() so that pinctrl_gpio_request() can be called.
> > The GPIO value is not modified when the user runs the "gpioset" tool.
> > This is because when gpiochip_generic_request is invoked by the
> > gpio-mlxbf3 driver, "pin_ranges" is empty so it skips "pinctrl_gpio_request()".
> > pinctrl_gpio_request() is essential in the code flow because it
> > changes the mux value so that software has control over modifying the GPIO
> value.
> > Adding add_pin_ranges() creates a dependency on the pinctrl-mlxbf3.c driver.
> >
> > Fixes: cd33f216d24 ("gpio: mlxbf3: Add gpio driver support")
> > Signed-off-by: Asmaa Mnebhi <asmaa@xxxxxxxxxx>
>
> You ignored my tag, why?
Oh, you already gave me a "Reviewed-By". Sorry I missed that. And Thank you! I will send a v5 with the tag.
Thanks.
Asmaa