Re: [PATCH v2 0/1] Add add-maintainer.py script
From: Guru Das Srinagesh
Date: Fri Aug 18 2023 - 21:49:26 EST
On Aug 18 2023 10:33, Neil Armstrong wrote:
> My opinion is that it would be a better idea to add a new output mode
> to scripts/get_maintainer.pl than adding another script on top of it.
Sorry, I don't follow. The problem that this script is solving is getting the
output of `get_maintainer.pl` neatly into a patch according to this scheme:
1. Generate patches using `git format-patch`
2. Run `add-maintainer.py` on the above patches
3. `git send-email` the patches.
Not sure how adding a new output mode to `get_maintainer.pl` fits in this
problem space.
Unless you mean to add a switch to it so that it automatically
edits the patch in-place (like `add-maintainer.py` does) and adds all the
addresses directly to the patch - in which case, that would be feature creep.
> Or document somewhere how to use get_maintainer.pl with git-format-patch
> without any additional scripts.
IMHO, `Documentation/process/submitting-patches.rst` should be updated with at
least one or two options addressing how to get from the aforementioned
step #1 -> step #3 addressing the problem that is being solved by step #2. In
this vacuum, every developer and maintainer appears to have their own solution
that works for them.
Thank you.
Guru Das.