Re: [PATCH v2 10/13] media: qcom: camss: Allow clocks vfeN vfe_liteN or vfe_lite

[Bryan O'Donoghue]

On 18/08/2023 13:30, Konrad Dybcio wrote:
> On 17.08.2023 16:38, Bryan O'Donoghue wrote:
> > The number of Video Front End - VFE or Image Front End - IFE supported
> > with new SoCs can vary both for the full and lite cases.
> >
> > For example sdm845 has one vfe_lite and two vfe interfaces with the vfe
> > clock called simply "vfe_lite" with no integer postfix. sc8280xp has four
> > vfe and four vfe lite blocks.
> >
> > We need to support the following clock name formats
> >
> > - vfeN
> > - vfe_liteN
> > - vfe_lite
> >
> > with N being any reasonably sized integer.
> >
> > There are two sites in this code which need to do the same thing,
> > constructing and matching strings with the pattern above, so encapsulate
> > the logic in one function.
> >
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > ---
> >   drivers/media/platform/qcom/camss/camss-vfe.c | 22 ++++++++++++++-----
> >   1 file changed, 16 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> > index 8f48401e31cd3..73380e75dbb22 100644
> > --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> > @@ -437,6 +437,20 @@ void vfe_isr_reset_ack(struct vfe_device *vfe)
> >   	complete(&vfe->reset_complete);
> >   }
> >   
> > +static int vfe_match_clock_names(struct vfe_device *vfe,
> > +				 struct camss_clock *clock)
> > +{
> > +	char vfe_name[CAMSS_RES_MAX];
> VFE_MAX?
>
> the current value of 17 would be very excessive for VFEs!
>
> Konrad

Solving these generic and large struct resource strings is something I 
plan for another series.

Good enough ?

---
bod