Re: [PATCH] dt-bindings: usb: Add ti,tps25750

[Abdel Alkuor]

On Sat, Aug 19, 2023 at 02:46:18PM +0200, Krzysztof Kozlowski wrote:
> On 18/08/2023 17:30, Abdel Alkuor wrote:
> > From: Abdel Alkuor <abdelalkuor@xxxxxxxxxx>
> > 
> > TPS25750 provides power negotiation and capabilities management
> > for USB Type-C applications.
> > 
> > Signed-off-by: Abdel Alkuor <abdelalkuor@xxxxxxxxxx>
> > ---
> > v2: 
> 
> git format-patch -v2 -1
Sorry about this. I realized after I sent the patch. Fixed in v3.
> 
> >  - Remove redundant word 'binding' from Subject
> >  - Add new line before reg property
> >  - Remove unused description in interrupts property
> >  - Drop interrupt-names property
> >  - Add maxItems to firmware-name property
> >  - Use generic node name 'typec' instead of 'tps25750'
> > ---
> >  .../devicetree/bindings/usb/ti,tps25750.yaml  | 81 +++++++++++++++++++
> >  1 file changed, 81 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/usb/ti,tps25750.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/ti,tps25750.yaml b/Documentation/devicetree/bindings/usb/ti,tps25750.yaml
> > new file mode 100644
> > index 000000000000..d98c34df340d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/ti,tps25750.yaml
> > @@ -0,0 +1,81 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/usb/ti,tps25750.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Texas Instruments 25750 Type-C Port Switch and Power Delivery controller
> > +
> > +maintainers:
> > +  - Abdel Alkuor <abdelalkuor@xxxxxxxxxx>
> > +
> > +description: |
> > +  Texas Instruments 25750 Type-C Port Switch and Power Delivery controller
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - ti,tps25750
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  firmware-name:
> > +    description: |
> > +      Should contain the name of the default patch binary
> > +      file located on the firmware search path which is
> > +      used to switch the controller into APP mode
> > +    maxItems: 1
> > +
> > +  connector:
> > +    type: object
> > +    $ref: ../connector/usb-connector.yaml#
> > +    description:
> > +      Properties for usb c connector.
> > +    required:
> > +      - data-role
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - connector
> > +
> > +additionalProperties: true
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        typec: tps25750@21 {
> 
> Nothing improved in node name. Drop the label "typec", because it is not
> used.
> 
> I still wait for the user, as I wrote in your v1.
Dropped the label and used typec@21 as the node name in v3
> 
> Best regards,
> Krzysztof
>

Thank you,
Abdel