Re: [PATCH] dt-bindings: trivial-devices: Remove the OV5642 entry
From: Krzysztof Kozlowski
Date: Sun Aug 20 2023 - 04:26:08 EST
On 01/08/2023 23:57, Conor Dooley wrote:
> On Tue, Aug 01, 2023 at 06:43:58PM -0300, Fabio Estevam wrote:
>> Hi Conor,
>>
>> On 01/08/2023 18:28, Conor Dooley wrote:
>>
>>> I never said it was chief. Please re-read the quoted text.
>>
>> trivial-devices.yaml throws the following warning:
>>
>> imx6q-sabrelite.dtb: camera@42: 'clock-names', 'clocks', 'gp-gpios', 'port',
>> 'powerdown-gpios', 'reset-gpios' do not match any of the regexes:
>> 'pinctrl-[0-9]+'
>> from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
>>
>> Would it make sense to remove ovti,ov5642 from the trivial-devices bindings
>> as well as from the
>> following devicetrees?
>
> I would rather that you documented it, rather than removed it, please.
Removal from DTS is rather discouraged, because DTS and these nodes
could be used in other systems. The best is to fully document the
device, regardless whether Linux supports it or not.
Dropping from trivial-devices could work, because it does not change
much for our schema - one warning goes to other warning...
Best regards,
Krzysztof