Re: [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver
From: Krzysztof Kozlowski
Date: Sun Aug 20 2023 - 16:29:14 EST
On 20/08/2023 18:46, Devarsh Thakkar wrote:
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - items:
>>> + - const: ti,e5010-jpeg-enc
>>
>> TI did not make e5010. Use SoC-based compatible.
>>
>>> + - const: img,e5010-jpeg-enc
>>> + - const: img,e5010-jpeg-enc
>>
>> img,e5010-jpeg-enc cannot be compatible with img,e5010-jpeg-enc. It does
>> not make sense. I guess I did not expect you are going to use what you
>> wrote in v1 directly... I thought it is just about syntax.
>>
>
> Sorry but I did not understand this fully, the possible compatibles are:
>
> 1) "ti,am62a-jpeg-enc", "img,e5010-jpeg-enc"
> or
> 2) "img,e5010-jpeg-enc"
>
> anything else will not comply during dtbs_check as shown below :
Ah, you are right, ENOTENOUGHCOFFEE or some other issue on my side.
>
> For e.g. If I use below compatible :
> "img,e5010-jpeg-enc", "img,e5010-jpeg-enc"
>
> and run dtbs_check, it throw below error :
>
> make CHECK_DTBS=y DT_SCHEMA_FILES=media/img,e5010-jpeg-enc.yaml
> ti/k3-am62a7-sk.dtb
> LINT Documentation/devicetree/bindings
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> DTC_CHK arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb
> /home/devarsht/ti/linux-next2/linux-next/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb:
> jpeg-encoder@fd20000: compatible: 'oneOf' conditional failed, one must
> be fixed:
> ['img,e5010-jpeg-enc', 'img,e5010-jpeg-enc'] is too long
> 'ti,am62a-jpeg-enc' was expected
> From schema:
> /home/devarsht/ti/linux-next2/linux-next/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
>
>
> Similarly, if I use below compatible :
>
> "ti,am62a-jpeg-enc",
> It throw below error :
>
> make CHECK_DTBS=y DT_SCHEMA_FILES=media/img,e5010-jpeg-enc.yaml
> ti/k3-am62a7-sk.dtb
> DTC_CHK arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb
> /home/devarsht/ti/linux-next2/linux-next/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb:
> jpeg-encoder@fd20000: compatible: 'oneOf' conditional failed, one must
> be fixed:
> ['ti,am62a-jpeg-enc'] is too short
> 'img,e5010-jpeg-enc' was expected
> From schema:
> /home/devarsht/ti/linux-next2/linux-next/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
>
>
> But If I use either 1) or 2) it does not throw any error.
> Please let me know if I missed to understand your point.
Yes, you are right, sorry for that.
However it still should be "ti,am62a-jpeg-enc", not ti,e5010...
Best regards,
Krzysztof