Re: [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()

From: Joel Stanley
Date: Mon Aug 21 2023 - 00:58:10 EST


On Wed, 16 Aug 2023 at 17:20, Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>
> struct i2c_driver::probe_new is about to go away. Switch the driver to
> use the probe callback with the same prototype.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> Hello,
>
> this driver appeared in next just today. I intend to drop .probe_new
> from struct i2c_driver after v6.6-rc1, so it would be great if this
> patch would go in together with the commit adding this driver.

Reviewed-by: Joel Stanley <joel@xxxxxxxxx>

Greg, can you please take this for 6.6?

>
> Thanks
> Uwe
>
> drivers/fsi/fsi-master-i2cr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
> index 61659c27a973..40f1f4d231e5 100644
> --- a/drivers/fsi/fsi-master-i2cr.c
> +++ b/drivers/fsi/fsi-master-i2cr.c
> @@ -301,7 +301,7 @@ static const struct of_device_id i2cr_ids[] = {
> MODULE_DEVICE_TABLE(of, i2cr_ids);
>
> static struct i2c_driver i2cr_driver = {
> - .probe_new = i2cr_probe,
> + .probe = i2cr_probe,
> .remove = i2cr_remove,
> .driver = {
> .name = "fsi-master-i2cr",
>
> base-commit: 53e89e3e4490d6630a68e61a3cb478e7a7f2ce8b
> --
> 2.40.1
>