Re: [PATCH 2/2] gpio: mxc: switch to dynamic allocat GPIO base

[Alexander Stein]

Hi Linus,

Am Montag, 21. August 2023, 09:25:54 CEST schrieb Linus Walleij:
> On Mon, Aug 21, 2023 at 4:47 AM Bough Chen <haibo.chen@xxxxxxx> wrote:> > Hi 
Linus and Bartosz,
> > 
> > For this patch, still not in the main trunk (Linux 6.5-rc7) and
> > linux-next(next-20230818). Can you help apply or any comment?
> 
> As pointed out by Bartosz you cannot just mechanically switch the base
> to -1.
> 
> You also need to convince us that this doesn't break any systems, and if
> it does, fix them so they don't break before submitting this patch.

I think it's hard to tell if something breaks, this driver is used in a lot of 
boards. AFAIR some people are relying on the assumption of fixed order. Using 
dynamic allocation this not ensured. A possible fix is to use aliases [1].

Best regards,
Alexander

[1] https://lore.kernel.org/lkml/20230215092421.143199-1-alexander.stein@xxxxxxxxxxxxxxx/T/#u
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/