Re: [PATCH v1 1/1] serial: core: Remove unused PORT_* definitions
From: Andy Shevchenko
Date: Mon Aug 21 2023 - 04:24:51 EST
On Mon, Aug 21, 2023 at 11:22:49AM +0300, Andy Shevchenko wrote:
> On Fri, Aug 18, 2023 at 02:12:29PM +0300, Andy Shevchenko wrote:
> > For the last couple of years Linux kernel got rid of a few architectures
> > and many platforms. Hence some PORT_* definitions in the serial_core.h
> > become unused and redundant. Remove them for good.
>
> Below are results via Debian Code Search.
>
> Note, I excluded Linux kernel itself from the "user" and Hurd, which seems
> to have Linux kernel v2.6 which is _provider_ of the definition(s).
...
> > -#define PORT_RM9000 16 /* PMC-Sierra RM9xxx internal UART */
>
> ifdeffed, safe to remove.
Actually on the second thought, this can bring a collision in case someone adds
another ID with the same value.
I'll issue the v2 with this line left untouched.
--
With Best Regards,
Andy Shevchenko