Re: [PATCH 2/6] soc/tegra: fuse: Add function to register nvmem

[Kartik]

On Fri, 2023-08-18 at 16:50 +0300, Andy Shevchenko wrote:

>On Fri, Aug 18, 2023 at 03:00:24PM +0530, Kartik wrote:
>> Add helper function tegra_fuse_nvmem_register() to register
>> Tegra Fuse nvmem and use it in tegra_fuse_probe(). So, this can be
>> shared between device-tree and ACPI probe, which is to be introduced
>> later.
>
>...
>
>> +	fuse->nvmem = devm_nvmem_register(dev, &nvmem);
>> +	if (IS_ERR(fuse->nvmem)) {
>
>> +		err = PTR_ERR(fuse->nvmem);
>> +		dev_err(dev, "failed to register NVMEM device: %d\n",
>> +			err);
>> +		return err;
>
>		return dev_err_probe();
>
>> +	}
>> +
>> +	return 0;
>> +}
>
>...
>
>Seems it comes from the original code, so consider this as a suggestion for
>an additional improvement.
>
>-- 
>With Best Regards,
>Andy Shevchenko

Thanks Andy, I will update this.


Regards,
Kartik