Re: [PATCH] ACPI: PHAT: Add Platform Health Assessment Table support

[Limonciello, Mario]

On 8/21/2023 12:12 PM, Rafael J. Wysocki wrote:
<snip>
> > I was just talking to some colleagues about PHAT recently as well.
> >
> > The use case that jumps out is "system randomly rebooted while I was
> > doing XYZ".  You don't know what happened, but you keep using your
> > system.  Then it happens again.
> >
> > If the reason for the random reboot is captured to dmesg you can cross
> > reference your journal from the next boot after any random reboot and
> > get the reason for it.  If a user reports this to a Gitlab issue tracker
> > or Bugzilla it can be helpful in establishing a pattern.
> >
> > > > The below location may be appropriate in that case:
> > > > /sys/firmware/acpi/
> > >
> > > Yes, it may. >
> > > > We already have FPDT and BGRT being exported from there.
> > >
> > > In fact, all of the ACPI tables can be retrieved verbatim from
> > > /sys/firmware/acpi/tables/ already, so why exactly do you want the
> > > kernel to parse PHAT in particular?
> >
> > It's not to say that /sys/firmware/acpi/PHAT isn't useful, but having
> > something internal to the kernel "automatically" parsing it and saving
> > information to a place like the kernel log that is already captured by
> > existing userspace tools I think is "more" useful.
>
> What existing user space tools do you mean?  Is there anything already
> making use of the kernel's PHAT output?

I was meaning things like systemd already capture the kernel long 
ringbuffer.  If you save stuff like this into the kernel log, it's going 
to be indexed and easier to grep for boots that had it.

> And why can't user space simply parse PHAT by itself?
>  > There are multiple ACPI tables that could be dumped into the kernel
> log, but they aren't.  Guess why.

Right; there's not reason it can't be done by userspace directly.

Another way to approach this problem could be to modify tools that 
excavate records from a reboot to also get PHAT.  For example 
systemd-pstore will get any kernel panics from the previous boot from 
the EFI pstore and put them into /var/lib/systemd/pstore.

No reason that couldn't be done automatically for PHAT too.