Re: [PATCH 2/2] dt-bindings: regulator: Add MAX77503 regulator bindings

[Krzysztof Kozlowski]

On 21/08/2023 18:28, Gokhan Celik wrote:
> Add bindings for MAX77503 buck converter.
> 
> Signed-off-by: Gokhan Celik <gokhan.celik@xxxxxxxxxx>

Subject:
regulator: dt-bindings:

and drop final, redundant "bindings"

> ---
>  .../regulator/adi,max77503-regulator.yaml     | 64 +++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77503-regulator.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/adi,max77503-regulator.yaml b/Documentation/devicetree/bindings/regulator/adi,max77503-regulator.yaml
> new file mode 100644
> index 000000000000..0d351225e107
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/adi,max77503-regulator.yaml

Filename like compatible.

> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) 2023 Analog Devices, Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/adi,max77503-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices MAX77503 Buck Converter
> +
> +maintainers:
> +  - Gokhan Celik <Gokhan.Celik@xxxxxxxxxx>
> +
> +description: Analog Devices MAX77503 Buck Converter
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,max77503
> +
> +  reg:
> +    description: I2C address of the device
> +    items:
> +      - enum: [0x1e, 0x24, 0x37]
> +
> +  regulator:

Why having this intermediate node? It's useless for one regulator, isn't it?


> +    type: object
> +    $ref: regulator.yaml#
> +    additionalProperties: false

You should rather use unevaluatedProperties:false and drop these ":true"
properties below.

> +    description: |
> +      Buck regulator
> +
> +    properties:
> +      regulator-name: true

Drop

> +      regulator-always-on: true

Drop

> +      regulator-boot-on: true

Drop

> +      regulator-min-microvolt:
> +        minimum: 800000

maximum?

> +      regulator-max-microvolt:
> +        maximum: 5000000

minimum?

> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        max77503@1e {

regulator@1e

> +            compatible = "adi,max77503";
> +            reg = <0x1e>;
> +            regulator{
> +                regulator-name = "max777503-regulator";
> +                regulator-min-microvolt = <800000>;
> +                regulator-max-microvolt = <5000000>;
> +                regulator-boot-on;
> +            };
> +        };
> +    };
> +

Best regards,
Krzysztof