Re: [PATCH 2/4] arm: dts: qcom: Add the rpmhpd header

[Rohit Agarwal]

On 8/21/2023 8:44 PM, Rob Herring wrote:
> On Mon, Jul 31, 2023 at 10:55:02AM +0530, Rohit Agarwal wrote:
> > Add the rpmhpd header having the definition of the regulator levels
> > for Qualcomm SoCs.
> >
> > Signed-off-by: Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 1 +
> >   arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 1 +
> >   2 files changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> > index df3cd9c..8ffb2a0 100644
> > --- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> > +++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> > @@ -12,6 +12,7 @@
> >   #include <dt-bindings/interconnect/qcom,sdx55.h>
> >   #include <dt-bindings/interrupt-controller/arm-gic.h>
> >   #include <dt-bindings/power/qcom-rpmpd.h>
> > +#include <dt-bindings/power/qcom,rpmhpd.h>
> If patch 4 isn't applied, aren't you going to get warnings about
> redefining the defines since you have them twice?
Isnt that just a macro so redefining wont give any warning. Please 
correct me if I am wrong.
But, I dont see any warnings while compiling without the 4th patch.

Thanks,
Rohit.
> >   #include <dt-bindings/soc/qcom,rpmh-rsc.h>
> >   
> >   / {
> > diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
> > index 1a35830..f990f5d 100644
> > --- a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
> > +++ b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
> > @@ -11,6 +11,7 @@
> >   #include <dt-bindings/gpio/gpio.h>
> >   #include <dt-bindings/interrupt-controller/arm-gic.h>
> >   #include <dt-bindings/power/qcom-rpmpd.h>
> > +#include <dt-bindings/power/qcom,rpmhpd.h>
> >   #include <dt-bindings/soc/qcom,rpmh-rsc.h>
> >   #include <dt-bindings/interconnect/qcom,sdx65.h>
> >   
> > --
> > 2.7.4