Re: [PATCH v3 0/9] selftests/sgx: Fix compilation errors

[Jarkko Sakkinen]

On Sat Aug 19, 2023 at 12:43 PM EEST, Jo Van Bulck wrote:
> Hi,
>
> This is the third iteration of a patch series to ensure that all SGX selftests
> succeed when compiling with optimizations (as tested with -O{0,1,2,3,s} for
> both gcc 11.3.0 and clang 14.0.0). The aim of the patches is to avoid reliance
> on undefined, compiler-specific behavior that can make the test results
> fragile.
>
> If useful, I can also include an elementary wrapper shell script to compile and
> run the tests for different compilers (gcc/clang) and optimization levels.
> Reference output below:
>
> .. Testing gcc   -O0    [OK]
> .. Testing gcc   -O1    [OK]
> .. Testing gcc   -O2    [OK]
> .. Testing gcc   -O3    [OK]
> .. Testing gcc   -Os    [OK]
> .. Testing gcc   -Ofast [OK]
> .. Testing gcc   -Og    [OK]
> .. Testing clang -O0    [OK]
> .. Testing clang -O1    [OK]
> .. Testing clang -O2    [OK]
> .. Testing clang -O3    [OK]
> .. Testing clang -Os    [OK]
> .. Testing clang -Ofast [OK]
> .. Testing clang -Og    [OK]
>
> Changelog
> ---------
>
> v3
>   - Refactor encl_op_array declaration and indexing (Jarkko)
>   - Annotate encl_buffer with "used" attribute (Kai)
>   - Split encl_buffer size and placement commits (Kai)
>
> v2
>   - Add additional check for NULL pointer (Kai)
>   - Refine to produce proper static-pie executable
>   - Fix linker script assertions
>   - Specify memory clobber for inline asm instead of volatile (Kai)
>   - Clarify why encl_buffer non-static (Jarkko, Kai)
>   - Clarify -ffreestanding (Jarkko)
>
> Best,
> Jo
>
> Jo Van Bulck (9):
>   selftests/sgx: Fix uninitialized pointer dereference in error path
>   selftests/sgx: Produce static-pie executable for test enclave
>   selftests/sgx: Handle relocations in test enclave
>   selftests/sgx: Fix linker script asserts
>   selftests/sgx: Include memory clobber for inline asm in test enclave
>   selftests/sgx: Ensure test enclave buffer is entirely preserved
>   selftests/sgx: Ensure expected location of test enclave buffer
>   selftests/sgx: Separate linker options
>   selftests/sgx: Specify freestanding environment for enclave
>     compilation
>
>  tools/testing/selftests/sgx/Makefile          | 14 ++--
>  tools/testing/selftests/sgx/defines.h         |  2 +
>  tools/testing/selftests/sgx/sigstruct.c       |  5 +-
>  tools/testing/selftests/sgx/test_encl.c       | 66 ++++++++++++-------
>  tools/testing/selftests/sgx/test_encl.lds     | 10 +--
>  .../selftests/sgx/test_encl_bootstrap.S       | 12 ++--
>  6 files changed, 68 insertions(+), 41 deletions(-)
>
> -- 
> 2.25.1

Looks "almost there" to me. Just had one query about freestanding.

BR, Jarkko