Re: [PATCH AUTOSEL 4.14 7/9] fs/nls: make load_nls() take a const parameter

[Pavel Machek]

On Sun 2023-08-13 12:14:25, Sasha Levin wrote:
> From: Winston Wen <wentao@xxxxxxxxxxxxx>
> 
> [ Upstream commit c1ed39ec116272935528ca9b348b8ee79b0791da ]
> 
> load_nls() take a char * parameter, use it to find nls module in list or
> construct the module name to load it.
> 
> This change make load_nls() take a const parameter, so we don't need do
> some cast like this:
> 
>         ses->local_nls = load_nls((char *)ctx->local_nls->charset);

Nice cleanup, but should not be in stable.

Best regards,
								Pavel
							
> Suggested-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Winston Wen <wentao@xxxxxxxxxxxxx>
> Reviewed-by: Paulo Alcantara <pc@xxxxxxxxxxxxx>
> Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>
> Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
>  fs/nls/nls_base.c   | 4 ++--
>  include/linux/nls.h | 2 +-

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature