Re: [PATCH] selftests: alsa: make LDLIBS consistent

[Mark Brown]

On Tue, Aug 22, 2023 at 10:15:45AM -0300, Ricardo B. Marliere wrote:

> In kselftest_deps.sh script, the level 3 parser is broken for the alsa
> subsystem Makefile.

>  CFLAGS += $(shell pkg-config --cflags alsa)
> -LDLIBS += $(shell pkg-config --libs alsa)
> -ifeq ($(LDLIBS),)
> -LDLIBS += -lasound
> +VAR_LDLIBS += $(shell pkg-config --libs alsa)
> +ifeq ($(VAR_LDLIBS),)
> +VAR_LDLIBS += -lasound

This seems like an undocumented bodge for whatever limitation the
checker script has.  If nothing else someone might come along later and
switch back to using the standard variable name, and TBH it does feel
like it'd be better to teach the checker to understand the pkg-config
idiom here.

Attachment: signature.asc
Description: PGP signature