Re: [PATCH 1/3] blk-mq: fix tags leak when shrink nr_hw_queues

From: Jens Axboe
Date: Tue Aug 22 2023 - 10:58:35 EST



On Mon, 21 Aug 2023 17:56:00 +0800, chengming.zhou@xxxxxxxxx wrote:
> Although we don't need to realloc set->tags[] when shrink nr_hw_queues,
> we need to free them. Or these tags will be leaked.
>
> How to reproduce:
> 1. mount -t configfs configfs /mnt
> 2. modprobe null_blk nr_devices=0 submit_queues=8
> 3. mkdir /mnt/nullb/nullb0
> 4. echo 1 > /mnt/nullb/nullb0/power
> 5. echo 4 > /mnt/nullb/nullb0/submit_queues
> 6. rmdir /mnt/nullb/nullb0
>
> [...]

Applied, thanks!

[1/3] blk-mq: fix tags leak when shrink nr_hw_queues
commit: e1dd7bc93029024af5688253b0c05181d6e01f8e
[2/3] blk-mq: delete redundant tagset map update when fallback
commit: 2bc4d7a355a4d617452eaf1b21d6d261194b3667
[3/3] blk-mq: prealloc tags when increase tagset nr_hw_queues
commit: 7222657e51b5626d10154b3e48ad441c33b5da96

Best regards,
--
Jens Axboe