Re: [PATCH v5 04/37] arm64/gcs: Document the ABI for Guarded Control Stacks

From: Szabolcs Nagy
Date: Tue Aug 22 2023 - 11:05:59 EST


just nits.

The 08/22/2023 14:56, Mark Brown wrote:
> +3. Allocation of Guarded Control Stacks
> +----------------------------------------
...
> +* Stacks allocated using map_shadow_stack() must be larger than 8 bytes and
> + must be 8 bytes aligned.

"the size must be multiple of 8 bytes."

> +
> +* An address can be specified to map_shadow_stack(), if one is provided then
> + it must be aligned to a page boundary.
...
> +5. Signal return
> +-----------------
...
> +
> +7. ptrace extensions
> +---------------------

section 6. is missing