Re: [PATCH v5 2/2] usb: typec: qcom-pmic-typec: register drm_bridge

[Bryan O'Donoghue]

On 22/08/2023 14:54, Heikki Krogerus wrote:
> On Thu, Aug 17, 2023 at 06:08:24PM +0300, Dmitry Baryshkov wrote:
> > The current approach to handling DP on bridge-enabled platforms requires
> > a chain of DP bridges up to the USB-C connector. Register a last DRM
> > bridge for such chain.
> >
> > Acked-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> >   drivers/usb/typec/tcpm/Kconfig                |  1 +
> >   drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 37 +++++++++++++++++++
> >   2 files changed, 38 insertions(+)
> >
> > diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
> > index 5d393f520fc2..0b2993fef564 100644
> > --- a/drivers/usb/typec/tcpm/Kconfig
> > +++ b/drivers/usb/typec/tcpm/Kconfig
> > @@ -79,6 +79,7 @@ config TYPEC_WCOVE
> >   config TYPEC_QCOM_PMIC
> >   	tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver"
> >   	depends on ARCH_QCOM || COMPILE_TEST
> > +	depends on DRM || DRM=n
> >   	help
> >   	  A Type-C port and Power Delivery driver which aggregates two
> >   	  discrete pieces of silicon in the PM8150b PMIC block: the
>
> Would it be an option to put the below in separate c file that you
> just compile based on CONFIG_DRM?
>
>          obj-$(CONFIG_TYPEC_QCOM_PMIC)           += qcom_pmic_tcpm.o
>          qcom_pmic_tcpm-y                        += qcom_pmic_typec.o \
>                                                     qcom_pmic_typec_port.o \
>                                                     qcom_pmic_typec_pdphy.o
>          ifneq ($(CONFIG_DRM),)
>                 qcom_pmic_tcpm-y                 += qcom_pmic_bridge_func.o
>          endif
>
> Thouse ifdefs in c file just look a bit rough to me.

+1 if that's possible.

Sounds nice.

---
bod