Re: [PATCH v1 1/1] watchdog: simatic: Use idiomatic selection of P2SB
From: Guenter Roeck
Date: Tue Aug 22 2023 - 12:39:45 EST
On Tue, Aug 22, 2023 at 05:18:59PM +0300, Andy Shevchenko wrote:
> While it's pretty much theoretical to be otherwise, make sure
> that P2SB is selected only for X86. This is idiomatic dependency
> which is used by all others who select it. Use it for Simatic
> as well.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Hans, can you take this one as well ?
Thanks,
Guenter
> ---
> drivers/watchdog/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index a75f6acb986b..751458959411 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1685,7 +1685,7 @@ config SIEMENS_SIMATIC_IPC_WDT
> depends on SIEMENS_SIMATIC_IPC && PCI
> default y
> select WATCHDOG_CORE
> - select P2SB
> + select P2SB if X86
> help
> This driver adds support for several watchdogs found in Industrial
> PCs from Siemens.
> --
> 2.40.0.1.gaa8946217a0b
>