Re: [PATCH v8 2/7] phy: Add HDMI configuration options
From: Dmitry Baryshkov
Date: Tue Aug 22 2023 - 13:22:19 EST
On 22/08/2023 16:54, Vinod Koul wrote:
> On 17-08-23, 13:05, Dmitry Baryshkov wrote:
>> On 08/08/2023 11:32, Sandor Yu wrote:
>>> Allow HDMI PHYs to be configured through the generic
>>> functions through a custom structure added to the generic union.
>>>
>>> The parameters added here are based on HDMI PHY
>>> implementation practices. The current set of parameters
>>> should cover the potential users.
>>>
>>> Signed-off-by: Sandor Yu <Sandor.yu@xxxxxxx>
>>> ---
>>> include/linux/phy/phy-hdmi.h | 24 ++++++++++++++++++++++++
>>> include/linux/phy/phy.h | 7 ++++++-
>>> 2 files changed, 30 insertions(+), 1 deletion(-)
>>> create mode 100644 include/linux/phy/phy-hdmi.h
>>
>> I think this looks good now, thank you!
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>
> Should this go thru drm or phy...?
I'd say, PHY, together with the other PHY patches. If you can merge
them into an immutable branch, then it can also be merged into
drm-misc (?) to provide the dependency between drm and phy parts.
--
With best wishes
Dmitry