Re: [PATCH v3 4/5] net: hpe: Add GXP UMAC Driver

[Hawkins, Nick]

> <include/net/page_pool/helpers.h>

Hi Andrew,

I can't seem to find this file in linux master. Where is it?

> Take a look at driver/net/ethernet/freescale/fec_main.c That
> driver/device is of similar complexity to yours. It had a recent
> change from its own buffer management to page pool. It
> started with

I have looked over this driver and have a couple questions
about the pages in general.

How do I determine what the correct pool size should be for the
RX and TX?

I must admit I am not familiar with XDP.
Is it required for the page pool library? Does it require any kind
of hardware enablement? Or is it just purely code?

Thanks for the feedback and assistance,

-Nick Hawkins