Re: [PATCH v1 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3

[Konrad Dybcio]

On 22.08.2023 21:03, Bryan O'Donoghue wrote:
> On 22/08/2023 17:32, Konrad Dybcio wrote:
>>>       val = 1 << CSI2_RX_CFG1_PACKET_ECC_CORRECTION_EN;
>>> +    if (vc > 3)
>> I hope you don't pull your hair out, but I think GENMASK(1,0) could be
> 
> 
> I generally dislike the pattern of 1 << value in this code but, it's not something I'm proposing to solve at this time.
> 
>> in order here with a comment about the bitlength requirements
> 
> Not parsing the bitlength requirements comment, whatdoyoumean ?
The thing you mentioned in the commit message, it could also be a
hint in the code above the if-statement.

Konrad