[PATCH v1 04/25] perf pmu: Reduce scope of perf_pmu_error

From: Ian Rogers
Date: Wed Aug 23 2023 - 04:13:58 EST


Move declaration from header file to pmu.y and make static.

Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
---
tools/perf/util/pmu.h | 1 -
tools/perf/util/pmu.y | 4 +++-
2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
index 9c9ea40b9c71..5394c85d20b9 100644
--- a/tools/perf/util/pmu.h
+++ b/tools/perf/util/pmu.h
@@ -227,7 +227,6 @@ int perf_pmu__check_alias(struct perf_pmu *pmu, struct list_head *head_terms,
struct perf_pmu_info *info);
struct list_head *perf_pmu__alias(struct perf_pmu *pmu,
struct list_head *head_terms);
-void perf_pmu_error(struct list_head *list, char *name, void *scanner, char const *msg);

int perf_pmu__new_format(struct list_head *list, char *name,
int config, unsigned long *bits);
diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
index 9bd9e30791ff..d861a5bfa3bd 100644
--- a/tools/perf/util/pmu.y
+++ b/tools/perf/util/pmu.y
@@ -21,6 +21,8 @@ do { \
YYABORT; \
} while (0)

+static void perf_pmu_error(struct list_head *list, char *name, void *scanner, char const *msg);
+
static void perf_pmu__set_format(unsigned long *bits, long from, long to)
{
long b;
@@ -93,7 +95,7 @@ PP_VALUE

%%

-void perf_pmu_error(struct list_head *list __maybe_unused,
+static void perf_pmu_error(struct list_head *list __maybe_unused,
char *name __maybe_unused,
void *scanner __maybe_unused,
char const *msg __maybe_unused)
--
2.42.0.rc1.204.g551eb34607-goog