Re: [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set_drvdata()

[Martin Kaiser]

Andrei Coardos (aboutphysycs@xxxxxxxxx) wrote:

> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>  drivers/char/hw_random/hisi-rng.c | 2 --
>  1 file changed, 2 deletions(-)

> diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
> index 96438f85cafa..b6f27566e0ba 100644
> --- a/drivers/char/hw_random/hisi-rng.c
> +++ b/drivers/char/hw_random/hisi-rng.c
> @@ -79,8 +79,6 @@ static int hisi_rng_probe(struct platform_device *pdev)
>  	if (!rng)
>  		return -ENOMEM;

> -	platform_set_drvdata(pdev, rng);
> -
>  	rng->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(rng->base))
>  		return PTR_ERR(rng->base);
> -- 
> 2.34.1

This one can go.

Reviewed-by: Martin Kaiser <martin@xxxxxxxxx>