Re: Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc

[Thomas Gleixner]

On Fri, Aug 18 2023 at 07:26, 黄少波 wrote:

Your patch is corrupt:

 Applying: Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc
 error: corrupt patch at line 12

It's DOS mangled and whitespace damaged.

> Whether to support 64-bit address status has been calculated before,
> and the calculation result can be used directly afterwards, so use
> msi_attrib.is_64 to avoid double calculation.

I'm not seeing what this solves:

> -       if (control & PCI_MSI_FLAGS_64BIT)
> +       if (desc.pci.msi_attrib.is_64)

Both variants resolve to a test of a bit and a conditional instruction
on the result. It's exactly zero difference in terms of "calculation".

So all this does is change the memory location to test. Not more not
less. It does not generate better code and does not save anything.

Thanks,

        tglx