Re: [PATCH] HID: cp2112: make the irqchip immutable

[Marc Zyngier]

On Wed, 23 Aug 2023 13:14:59 +0100,
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> 
> On Tue, Aug 22, 2023 at 5:22 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> 
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > This make the GPIO irqchip exposed by the CP2112 driver use an immutable
> > irq_chip struct thus addressing the following warning on probe:
> >
> >   (cp2112_gpio): not an immutable chip, please consider fixing it!
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> Thanks for fixing this. FWIW:
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> Marc Z, have you checked how we stand with immutable GPIO
> irqchips? We should be able to smoke it out to default behaviour
> soon I think.

I haven't recently checked, but I'm still in favour of actively
make the new behaviour the only one supported. The sooner we break
things, the better...

	M.

-- 
Without deviation from the norm, progress is not possible.