Re: [PATCH 1/2] dt-bindings: crypto: qcom,prng: document SM8550

[Om Prakash Singh]

On 8/23/2023 1:25 PM, Neil Armstrong wrote:
> Hi,
>
> On 23/08/2023 02:10, Om Prakash Singh wrote:
> > On 8/22/2023 9:34 PM, Konrad Dybcio wrote:
> > > On 22.08.2023 16:54, Om Prakash Singh wrote:
> > > > PRNG Block on most of newer target from Qualcomm have some 
> > > > configuration where clock is configured by security firmware.
> > > >
> > > > Adding separate compatible string for each platform is overhead.
> > > >
> > > > We need to introduce common compatible string that can be used for 
> > > > all platforms with same configuration.
> > > >
> > > > I would suggest to use "qcom,rng-ee" for newer platform, dropping 
> > > > "p" also signifies it is not a Pseudo Random Number Generator.
> > > Please reply inline and don't top-post.
> > >
> > >
> > > Is this what you're trying to say?
> > >
> > > 1. sort out the clock requirements for designs where Linux manages it
> > >     vs where the FW does so >
> > > 2. introduce a new compatible for SoCs implementing a TRNG
> > >
> > > 3. for SoCs in 2., register the TRNG as a hwrng device
> >
> > Yes to all
>
> I can send a proposal, but that means writing a new driver for this 
> compatible in drivers/char/hw_random/ right ?

We can add hwrng support in same driver like 
drivers/crypto/hisilicon/trng/trng.c

As Krzysztof is suggesting we need to have platform specific compatible 
string, we can go with your change. for hwrng support I will send 
separate patches.

> Neil
>
> > > ?
> > >
> > > Konrad
> >
> > Thanks,
> > Om