Re: [PATCH v5 13/19] sched: Split out __sched() deactivate task logic into a helper
From: kernel test robot
Date: Wed Aug 23 2023 - 20:39:27 EST
Hi John,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tip/locking/core]
[also build test WARNING on linus/master tip/auto-latest v6.5-rc7]
[cannot apply to tip/sched/core tip/master next-20230823]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/John-Stultz/sched-Unify-runtime-accounting-across-classes/20230821-121604
base: tip/locking/core
patch link: https://lore.kernel.org/r/20230819060915.3001568-14-jstultz%40google.com
patch subject: [PATCH v5 13/19] sched: Split out __sched() deactivate task logic into a helper
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20230824/202308240824.ugWLq8LH-lkp@xxxxxxxxx/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce: (https://download.01.org/0day-ci/archive/20230824/202308240824.ugWLq8LH-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308240824.ugWLq8LH-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> kernel/sched/core.c:6565:6: warning: no previous declaration for 'try_to_deactivate_task' [-Wmissing-declarations]
bool try_to_deactivate_task(struct rq *rq, struct task_struct *p, unsigned long state)
^~~~~~~~~~~~~~~~~~~~~~
vim +/try_to_deactivate_task +6565 kernel/sched/core.c
6564
> 6565 bool try_to_deactivate_task(struct rq *rq, struct task_struct *p, unsigned long state)
6566 {
6567 if (signal_pending_state(state, p)) {
6568 WRITE_ONCE(p->__state, TASK_RUNNING);
6569 } else {
6570 p->sched_contributes_to_load =
6571 (state & TASK_UNINTERRUPTIBLE) &&
6572 !(state & TASK_NOLOAD) &&
6573 !(state & TASK_FROZEN);
6574
6575 if (p->sched_contributes_to_load)
6576 rq->nr_uninterruptible++;
6577
6578 /*
6579 * __schedule() ttwu()
6580 * prev_state = prev->state; if (p->on_rq && ...)
6581 * if (prev_state) goto out;
6582 * p->on_rq = 0; smp_acquire__after_ctrl_dep();
6583 * p->state = TASK_WAKING
6584 *
6585 * Where __schedule() and ttwu() have matching control dependencies.
6586 *
6587 * After this, schedule() must not care about p->state any more.
6588 */
6589 deactivate_task(rq, p, DEQUEUE_SLEEP | DEQUEUE_NOCLOCK);
6590
6591 if (p->in_iowait) {
6592 atomic_inc(&rq->nr_iowait);
6593 delayacct_blkio_start();
6594 }
6595 return true;
6596 }
6597 return false;
6598 }
6599
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki