RE: [EXT] Re: [PATCH v2 net] octeontx2-pf: fix page_pool creation fail for rings > 32k

[Ratheesh Kannoth]

> From: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
> Sent: Wednesday, August 23, 2023 3:43 PM
> Subject: [EXT] Re: [PATCH v2 net] octeontx2-pf: fix page_pool creation fail
> for rings > 32k
> See now? I told ya you don't need that many to provide good recycling :> But
> nice to see it was confirmed 2k is enough.
Thanks !
 
> Isn't otx2_txrx.h a better place for this definition? For example, I'd place it
> somewhere between CGX_CHAN_BASE and OTX2_DATA_ALIGN. Or after
> MAX_XDP_MTU, doesn't matter much.
ACK.

> Don't forget about alignment. Otx2 code has very inconsistent alignment of
> definitions -- just one space in some places and proper tab alignment in
> others. I still believe we prefer the second for netdev code.
ACK.  Is it documented somewhere. I mean the coding std for netdev ?