Re: [PATCH 2/6] clk: qcom: gcc-ipq9574: Mark nssnoc clocks as critical

[Devi Priya]

On 7/11/2023 3:55 PM, Dmitry Baryshkov wrote:
> On 11/07/2023 12:35, Devi Priya wrote:
> > Mark nssnoc clocks as critical as they are to be turned on to access
> > nss port tx/rx clocks.
>
> Can you please clarify, if these are turned off, one can not access 
> nsscc clocks? Then the nsscc should be the consumer of these clocks 
> (instead of declaring them as critical). May be using pm_clk for nsscc 
> will work. If not, you'll have to do that manually from 
> runtime_suspend/runtime_resume callbacks.

Sure, will use pm_clk for nsscc in V2

Thanks,
Devi Priya
> > Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx>
> > ---
> >   drivers/clk/qcom/gcc-ipq9574.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/clk/qcom/gcc-ipq9574.c 
> > b/drivers/clk/qcom/gcc-ipq9574.c
> > index 6914f962c893..b68addc6f687 100644
> > --- a/drivers/clk/qcom/gcc-ipq9574.c
> > +++ b/drivers/clk/qcom/gcc-ipq9574.c
> > @@ -2166,7 +2166,7 @@ static struct clk_branch gcc_nssnoc_nsscc_clk = {
> >                   &pcnoc_bfdcd_clk_src.clkr.hw
> >               },
> >               .num_parents = 1,
> > -            .flags = CLK_SET_RATE_PARENT,
> > +            .flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
> >               .ops = &clk_branch2_ops,
> >           },
> >       },
> > @@ -2565,7 +2565,7 @@ static struct clk_branch gcc_nssnoc_snoc_clk = {
> >                   &system_noc_bfdcd_clk_src.clkr.hw
> >               },
> >               .num_parents = 1,
> > -            .flags = CLK_SET_RATE_PARENT,
> > +            .flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
> >               .ops = &clk_branch2_ops,
> >           },
> >       },
> > @@ -2582,7 +2582,7 @@ static struct clk_branch gcc_nssnoc_snoc_1_clk = {
> >                   &system_noc_bfdcd_clk_src.clkr.hw
> >               },
> >               .num_parents = 1,
> > -            .flags = CLK_SET_RATE_PARENT,
> > +            .flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
> >               .ops = &clk_branch2_ops,
> >           },
> >       },