Re: [PATCH v5 05/45] xenbus/backend: dynamically allocate the xen-backend shrinker

[Juergen Gross]

On 24.08.23 05:42, Qi Zheng wrote:
> Use new APIs to dynamically allocate the xen-backend shrinker.
>
> Signed-off-by: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
> Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
> CC: Juergen Gross <jgross@xxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> CC: xen-devel@xxxxxxxxxxxxxxxxxxxx

Acked-by: Juergen Gross <jgross@xxxxxxxx>

Just one note: it seems as if most users will set seeks to DEFAULT_SEEKS.
Wouldn't it be better to do this in shrinker_alloc() and let only callers
who want a different value overwrite that?


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature